Return the pk/id for docs in search #6544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR adds the primary key (id) into the search result JSON to allow the UI to correctly retrieve and handle click event data for document metadata editing.
- Added the "id" field to the result dictionary in the make_result function.
- Addresses the issue where search results did not include a unique identifier for related documents.
Reviewed Changes
| File | Description |
|---|---|
| kitsune/search/search.py | Added "id" field to include the primary key |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
akatsoulas
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue where related documents could not be added when editing document metadata.
The search was not returning a pk/id, thus the JS could not assign the pk to a returned result, rendering the JS helpless to receive click event data.
We should consider converting this to TomSelect or otherwise improving the UI/UX.